Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend enhancements for transformation plan request to better support UI #17071

Merged
merged 2 commits into from
Mar 5, 2018

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Feb 28, 2018

Small enhancements to transformation plan request

  1. Treat ServiceTemplateTransformationPlanRequest as backend only so that it does not show on the service requests screen
  2. Set the request's description the same as plan's name. The migration UI shows the request by description. The description can link to the plan.

So that it does not show on the service requests screen
@bzwei
Copy link
Contributor Author

bzwei commented Feb 28, 2018

@miq-bot add_label transformation, enhancement
@miq-bot assign @gmcculloug
@tinaafitz @mkanoor @lfu please review

@tinaafitz
Copy link
Member

@bzwei Looks good.

@@ -3,8 +3,13 @@ def self.base_model
ServiceTemplateTransformationPlanTask
end

def self.get_description(req_obj)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the example in parent class' implementation

@miq-bot
Copy link
Member

miq-bot commented Feb 28, 2018

Checked commits bzwei/manageiq@fbfaeec~...ba8d622 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

app/models/miq_request.rb

@gmcculloug gmcculloug merged commit b253433 into ManageIQ:master Mar 5, 2018
@gmcculloug gmcculloug added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 5, 2018
@bzwei bzwei deleted the v2v_request_desc branch March 5, 2018 15:47
simaishi pushed a commit that referenced this pull request May 31, 2018
Backend enhancements for transformation plan request to better support UI
(cherry picked from commit b253433)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit dc902b6565e3e64a2b34c72150275c5f059b3b47
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Mar 5 10:28:15 2018 -0500

    Merge pull request #17071 from bzwei/v2v_request_desc
    
    Backend enhancements for transformation plan request to better support UI
    (cherry picked from commit b253433b46c24bcc6056eafb24610ed78e55989b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants