Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #orderable? as alias method #17045

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Add #orderable? as alias method #17045

merged 1 commit into from
Feb 23, 2018

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Feb 23, 2018

orderable? is alias method of validate_order in ServiceTemplate.
Need to declare it as an alias again when overriding validate_order in ServiceTemplateMigrationPlan.

@bzwei
Copy link
Contributor Author

bzwei commented Feb 23, 2018

@miq-bot assign @gmcculloug
@miq-bot add_label transformation

@miq-bot
Copy link
Member

miq-bot commented Feb 23, 2018

Checked commit bzwei@feb5c23 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@gmcculloug gmcculloug merged commit 7c7f922 into ManageIQ:master Feb 23, 2018
@gmcculloug gmcculloug added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 23, 2018
@bzwei bzwei deleted the v2v_order branch February 23, 2018 19:43
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

@bzwei Please add BZ link.

@bzwei
Copy link
Contributor Author

bzwei commented Mar 7, 2018

@simaishi this is v2v new feature. No BZ is needed.

@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

@gmcculloug how are we differentiating what PRs need to go to gaprindashvili and not? When I look at PRs with transformation label (which I assume is v2v) in this repo, only this PR has gaprindashvili/yes label.

simaishi pushed a commit that referenced this pull request May 29, 2018
Add #orderable? as alias method
(cherry picked from commit 7c7f922)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 71ffa3f30d3a955550340bf018926a354cac14c3
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Feb 23 14:38:32 2018 -0500

    Merge pull request #17045 from bzwei/v2v_order
    
    Add #orderable? as alias method
    (cherry picked from commit 7c7f92255bef5e85db4c2ac461bf4b1ebfb15b83)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants