Stop container workers cleanly #17042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, when #stop_worker was called, we would attempt to scale the deployment. This would work if we had a different number (or zero) workers configured in the settings, but we don't shut workers down like that when shutting down the server to preserve the user's settings for the next startup. This resulted in worker pods not exiting when the orchestrator pod stopped and much confusion when the next orchestrator started up.
This will happen from time to time as we're calling #delete_container_objects on each worker instance. The calls to OpenShift are asynchronous so the next worker we tell to #delete_container_objects may try to delete objects that have already been removed. Additionally, this makes it difficult to track when objects have been deleted. Ideally we would scale a deployment down and have the last worker delete the deployment iteslf, but a previous worker may not have deleted the worker record by the time we tell the next worker to exit.
carbonin
force-pushed
the
stop_container_worker
branch
from
9f6efae
to
6f52ccb
Compare
|
Checked commits carbonin/manageiq@272a7ee~...6f52ccb with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, when #stop_worker was called, we would attempt to scale the deployment. This would work if we had a different number (or zero) workers configured in the settings, but we don't shut workers down like that when shutting down the server to preserve the user's settings for the next startup.
This resulted in worker pods not exiting when the orchestrator pod stopped and much confusion when the next orchestrator started up.
Additionally, this PR implements some error catching for the
ContainerOrchestratorwhich we need because requests to remove resources from OpenShift are asynchronous.