Fix replication validation for not saved subscriptions #16997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se or initializing subscription parameter
yrudman
force-pushed
the
fix-replication-validation-before-pglogical-schema-created
branch
from
9e47e18
to
b8e87e1
Compare
|
Checked commits yrudman/manageiq@31b4764~...b8e87e1 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
\cc @carbonin |
yrudman
deleted the
fix-replication-validation-before-pglogical-schema-created
branch
simaishi
pushed a commit
that referenced
this pull request
Mar 7, 2018
…ore-pglogical-schema-created Fix replication validation for not saved subscriptions (cherry picked from commit e7b6dce) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552790
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
While setting-up replication nodes on global region, validation throws errors if 'pglogical' schema not created first:
/usr/local/lib/ruby/gems/2.3.0/gems/pg-pglogical-2.1.2/lib/pg/pglogical/client.rb:344:in `async_exec' /usr/local/lib/ruby/gems/2.3.0/gems/pg-pglogical-2.1.2/lib/pg/pglogical/client.rb:344:in `typed_exec' /usr/local/lib/ruby/gems/2.3.0/gems/pg-pglogical-2.1.2/lib/pg/pglogical/client.rb:228:in `subscription_show_status' /var/www/miq/vmdb/app/models/pglogical_subscription.rb:211:in `find_password' /var/www/miq/vmdb/app/models/pglogical_subscription.rb:94:in `validate' /usr/local/lib/ruby/gems/2.3.0/bundler/gems/manageiq-ui-classic-02e1a7098b58/app/controllers/ops_controller/settings/common.rb:239:in `pglogical_validate_subscription'Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1544911
AFTER:
@miq-bot add-label bug, replication, gaprindashvili/yes