Two small fixes to tools/miqssh #16986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had added the realpath to be able to use aliases for the old commands, but that was not well thought out. Reverting to fix lots of stuff.
Ansible was producing an error from cat command with miqgrep nogrep from the "" when PATTERN was empty.
|
Checked commits jeffmcutter/manageiq@0fd94f3~...d282e0b with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 8, 2018
Two small fixes to tools/miqssh (cherry picked from commit e582ac7) https://bugzilla.redhat.com/show_bug.cgi?id=1553362
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 9, 2018
Two small fixes to tools/miqssh (cherry picked from commit e582ac7) https://bugzilla.redhat.com/show_bug.cgi?id=1553364
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Two small fixes to tools/miqssh (cherry picked from commit e582ac7) https://bugzilla.redhat.com/show_bug.cgi?id=1553364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove realpath for determining NAME in miqssh. This was a poor attempt to allow aliases of old names.
Fix miqgrep when used with nogrep option and ansible transport.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1552989