Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Use config 1.7.0 to be able to reset values to nil. #16982

Closed
wants to merge 1 commit into from
Closed

[WIP] Use config 1.7.0 to be able to reset values to nil. #16982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ gem "ancestry", "~>2.2.1", :require => false
gem "bcrypt", "~> 3.1.10", :require => false
gem "bundler", ">=1.11.1", :require => false
gem "color", "~>1.8"
gem "config", "~>1.6.0", :require => false
gem "config", "~>1.7.0", :require => false
gem "dalli", "~>2.7.4", :require => false
gem "default_value_for", "~>3.0.3"
gem "docker-api", "~>1.33.6", :require => false
Expand Down
6 changes: 3 additions & 3 deletions config/settings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@
:image_name: manageiq/embedded-ansible
:image_tag: latest
:service_account: miq-privileged
:ems:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This nil value for a key that's overridden by sub-settings causes those settings to be lost.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an example, this setting is overriding the ems key for other configuration sources: such as the amazon provider

# provider specific settings are nested here, but they are in the provider repos
# e.g.:
# :ems_<provider_name>:
# :use_feature: false
# :ems:
# :ems_<provider_name>:
# :use_feature: false
:event_streams:
:history:
:keep_events: 6.months
Expand Down