Use correct comparison for multi-value default value inclusion rules #16978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eclarizio Please see failing test and rubocop issues. |
https://bugzilla.redhat.com/show_bug.cgi?id=1531316 Since the default value for a multi-value drop-down is a string, comparing directly to the list of values in a drop-down did not work. It needs to be converted to an array and then compare the overlap to see if the default value is appropriate.
|
Checked commit eclarizio@d512174 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Feb 9, 2018
Use correct comparison for multi-value default value inclusion rules (cherry picked from commit 6056dc8) https://bugzilla.redhat.com/show_bug.cgi?id=1531316
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://bugzilla.redhat.com/show_bug.cgi?id=1531316, found while I was testing with a multi-value drop down. The default value was being set correctly but the actual drop down wasn't displaying the default. It was because it was trying to see if the default value existed within the list of values. When it's a multi-value drop down, something like
"[\"1\", \"2\"]"is not going to be one of the values, we have to parse it first and then check to see if there is any overlap.@miq-bot assign @gmcculloug
@miq-bot add_label gaprindashvili/yes, bug, blocker
/cc @romanblanco
@d-m-u Can you review, please?