Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping azure classic and rackspace credential types #16936

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

@jameswnl
Copy link
Contributor Author

jameswnl commented Feb 2, 2018

We may consider to port this to Gaprindashvili

@gmcculloug gmcculloug added the wip label Feb 2, 2018
@gmcculloug gmcculloug changed the title Dropping azure classic credential [WIP] Dropping azure classic credential Feb 2, 2018
@jameswnl jameswnl force-pushed the v2cred branch 2 times, most recently from bf6e740 to 4477b81 Compare February 5, 2018 19:03
@jameswnl jameswnl changed the title [WIP] Dropping azure classic credential Dropping azure classic and rackspace credential types Feb 5, 2018
@jameswnl
Copy link
Contributor Author

jameswnl commented Feb 5, 2018

@miq-bot add_label gaprindashvili/yes
@miq-bot remove_label wip

@miq-bot
Copy link
Member

miq-bot commented Feb 5, 2018

Checked commit jameswnl@cd4da8a with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@jameswnl
Copy link
Contributor Author

jameswnl commented Feb 6, 2018

The spec failure needs ManageIQ/manageiq-providers-ansible_tower#58

@jameswnl jameswnl closed this Feb 6, 2018
@jameswnl jameswnl reopened this Feb 6, 2018
@blomquisg blomquisg merged commit 97d3058 into ManageIQ:master Feb 6, 2018
@jameswnl
Copy link
Contributor Author

jameswnl commented Feb 6, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Feb 6, 2018
simaishi pushed a commit that referenced this pull request Feb 6, 2018
Dropping azure classic and rackspace credential types
(cherry picked from commit 97d3058)

https://bugzilla.redhat.com/show_bug.cgi?id=1542738
@simaishi
Copy link
Contributor

simaishi commented Feb 6, 2018

Gaprindashvili backport details:

$ git log -1
commit 937251385a9809cdf8144fa02fa528a515f481bb
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Tue Feb 6 13:28:10 2018 -0500

    Merge pull request #16936 from jameswnl/v2cred
    
    Dropping azure classic and rackspace credential types
    (cherry picked from commit 97d3058eb3a948efbaf303fd69743b9bd782e947)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1542738

gmcculloug added a commit to gmcculloug/manageiq-automation_engine that referenced this pull request Feb 7, 2018
@agrare agrare added this to the Sprint 79 Ending Feb 12, 2018 milestone Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants