Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added factories that are need to run spec tests in the BZ fix #16794

Conversation

h-kataria
Copy link
Contributor

https://bugzilla.redhat.com/show_bug.cgi?id=1533109

please review, need these factories to run spec tests in UI PR ManageIQ/manageiq-ui-classic#3221

@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2018

Checked commit h-kataria@ec848f2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@dclarizio dclarizio merged commit c3c5c40 into ManageIQ:master Jan 10, 2018
@dclarizio dclarizio added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 10, 2018
simaishi pushed a commit that referenced this pull request Jan 11, 2018
…nsible_credentials

Added factories that are need to run spec tests in the BZ fix
(cherry picked from commit c3c5c40)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 779e279460b38677958227c52fa0847e2c320efa
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed Jan 10 14:07:33 2018 -0800

    Merge pull request #16794 from h-kataria/added_factory_for_embedded_ansible_credentials
    
    Added factories that are need to run spec tests in the BZ fix
    (cherry picked from commit c3c5c40b53b38e885f9a6c33630a1846fbfbbc92)

@h-kataria h-kataria deleted the added_factory_for_embedded_ansible_credentials branch April 14, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants