Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions for Amazon tag mapping in graph refresh #16734

Merged
merged 2 commits into from
Jan 3, 2018

Conversation

cben
Copy link
Contributor

@cben cben commented Jan 3, 2018

For ManageIQ/manageiq-providers-amazon#382
cc @juliancheal @Ladas

https://bugzilla.redhat.com/show_bug.cgi?id=1506404

ems.vm_and_template_taggings resulting query:

SELECT "taggings".* FROM "taggings" 
INNER JOIN "tags" ON "tags"."id" = "taggings"."tag_id" 
LEFT OUTER JOIN "classifications" ON "classifications"."tag_id" = "tags"."id" 
INNER JOIN "vms" ON "taggings"."taggable_id" = "vms"."id" 
WHERE "vms"."ems_id" = 7 
  AND "taggings"."taggable_type" = 'VmOrTemplate' 
  AND (("tags"."name" LIKE '/managed/amazon:%') OR ("tags"."name" LIKE '/managed/kubernetes:%'))
  AND "classifications"."read_only" = 't' 
  AND ("classifications"."parent_id" != 0)
  • Tested manageiq-providers-kubernetes specs still pass, including tag mapping
  • Tested manageiq-providers-openshift specs still pass, including tag mapping

@juliancheal
Copy link
Member

This looks great @cben.

@juliancheal
Copy link
Member

@miq-bot assign @blomquisg

@miq-bot
Copy link
Member

miq-bot commented Jan 3, 2018

Checked commits cben/manageiq@ebe2008~...be7d05c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 3 offenses detected

app/models/manageiq/providers/cloud_manager.rb

@cben cben changed the title [WIP] Additions for Amazon tag mapping in graph refresh Additions for Amazon tag mapping in graph refresh Jan 3, 2018
@miq-bot miq-bot removed the wip label Jan 3, 2018
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍

@agrare agrare assigned agrare and unassigned blomquisg Jan 3, 2018
@agrare agrare merged commit cd17a20 into ManageIQ:master Jan 3, 2018
@agrare agrare added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 3, 2018
simaishi pushed a commit that referenced this pull request Jan 4, 2018
Additions for Amazon tag mapping in graph refresh
(cherry picked from commit cd17a20)

https://bugzilla.redhat.com/show_bug.cgi?id=1531291
@simaishi
Copy link
Contributor

simaishi commented Jan 4, 2018

Gaprindashvili backport details:

$ git log -1
commit ca48d863533b2a3a291d8cffbc03ba974bfca45c
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Jan 3 14:28:05 2018 -0500

    Merge pull request #16734 from cben/amazon-tag-mapping
    
    Additions for Amazon tag mapping in graph refresh
    (cherry picked from commit cd17a2033f306e6b107db56dc7ecf6c10a7596de)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531291

juliancheal pushed a commit to juliancheal/manageiq that referenced this pull request Feb 28, 2018
ManageIQ#16734

plus additional methods required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants