Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the zone name is unique only within the current region #16731

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Jan 2, 2018

This allows for properties of a zone in the global region to be
changed even if there is a zone with the same name in a remote region

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1467348

This allows for properties of a zone in the global region to be
changed even if there is a zone with the same name in a remote region

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1467348
@miq-bot
Copy link
Member

miq-bot commented Jan 3, 2018

Checked commit carbonin@ca3ed83 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy Fryguy merged commit 1bf5290 into ManageIQ:master Jan 3, 2018
@Fryguy Fryguy added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 3, 2018
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit ee61a824346dd35e646fc9895b92fe1612b2d5d7
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Jan 3 14:27:38 2018 -0500

    Merge pull request #16731 from carbonin/validate_zone_name_within_region
    
    Ensure that the zone name is unique only within the current region
    (cherry picked from commit 1bf5290e0bdae708be0f2e8c8122b5768af449c2)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530820

simaishi pushed a commit that referenced this pull request Jan 3, 2018
Ensure that the zone name is unique only within the current region
(cherry picked from commit 1bf5290)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530820
@bdunne
Copy link
Member

bdunne commented Apr 2, 2018

@bdunne bdunne added the fine/yes label Apr 2, 2018
simaishi pushed a commit that referenced this pull request Apr 9, 2018
Ensure that the zone name is unique only within the current region
(cherry picked from commit 1bf5290)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526156
@simaishi
Copy link
Contributor

simaishi commented Apr 9, 2018

Fine backport details:

$ git log -1
commit 759dda563fa3ba95bb8eab2e460064053d18de96
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Jan 3 14:27:38 2018 -0500

    Merge pull request #16731 from carbonin/validate_zone_name_within_region
    
    Ensure that the zone name is unique only within the current region
    (cherry picked from commit 1bf5290e0bdae708be0f2e8c8122b5768af449c2)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526156

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…thin_region

Ensure that the zone name is unique only within the current region
(cherry picked from commit 1bf5290)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526156
@carbonin carbonin deleted the validate_zone_name_within_region branch August 16, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants