Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Compute Infrastructure Hosts filter for ESX 6.5 #16703

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Dec 20, 2017

NOTE: Requires MiqSearch.seed in order to repopulate db table entries for proper UI display.

Fixes Hosts filter yaml file by adding a new definition filter of ESX 6.5

https://bugzilla.redhat.com/show_bug.cgi?id=1496582

Screen shot prior to code fix:
compute infra hosts filters prior to code fix

VMM Version 6.5.0 host created in db:
compute infra hosts 6 5 0 vmm version

VMM Version Host 6.5.0 selected via newly added filter:
compute infra hosts 6 5 0 filter selection post fix

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

Checked commit GregP@b1b0738 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@GregP
Copy link
Contributor Author

GregP commented Dec 20, 2017

@h-kataria Ready for review

@GregP
Copy link
Contributor Author

GregP commented Dec 21, 2017

@h-kataria Modified db record to be 6.5.0 and added screen shots from UI. Ready for review.

@h-kataria h-kataria self-assigned this Dec 21, 2017
@h-kataria h-kataria added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 21, 2017
@h-kataria h-kataria merged commit bb9f922 into ManageIQ:master Dec 21, 2017
simaishi pushed a commit that referenced this pull request Jan 3, 2018
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 5952273251d719d04735eb58f0e1c4bc6bb052f2
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Dec 21 15:43:10 2017 -0500

    Merge pull request #16703 from GregP/compute_infra_hosts_filter_esx65
    
    Add Compute Infrastructure Hosts filter for ESX 6.5
    (cherry picked from commit bb9f9229e3cf77fb3ffa0bd5721a31240465f0e4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530706

simaishi pushed a commit that referenced this pull request Jan 4, 2018
@simaishi
Copy link
Contributor

simaishi commented Jan 4, 2018

Fine backport details:

$ git log -1
commit b384b13e301104ee2218cc32d53c422a4b52bec5
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Dec 21 15:43:10 2017 -0500

    Merge pull request #16703 from GregP/compute_infra_hosts_filter_esx65
    
    Add Compute Infrastructure Hosts filter for ESX 6.5
    (cherry picked from commit bb9f9229e3cf77fb3ffa0bd5721a31240465f0e4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530708

simaishi pushed a commit that referenced this pull request Feb 26, 2018
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 2a882b0456004abb0b8aa516fab768cc0921b080
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Dec 21 15:43:10 2017 -0500

    Merge pull request #16703 from GregP/compute_infra_hosts_filter_esx65
    
    Add Compute Infrastructure Hosts filter for ESX 6.5
    (cherry picked from commit bb9f9229e3cf77fb3ffa0bd5721a31240465f0e4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1549249

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…er_esx65

Add Compute Infrastructure Hosts filter for ESX 6.5
(cherry picked from commit bb9f922)

https://bugzilla.redhat.com/show_bug.cgi?id=1530708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants