Make ContainerLogger respond to #instrument #16694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a container, the instance of ContainerLogger is sent every message recieved by the other logger instances In the case of FogLogger we have had to add additional messages to deal with the Econ gem's requirements around logging requests. This failure manifests itself as a failure to validate credentials on providers which use Fog when running in a container. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527546
|
Checked commit carbonin@81343e8 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 lib/vmdb/loggers.rb
|
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
…ogger Make ContainerLogger respond to #instrument (cherry picked from commit 05b53f1) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530637
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a container, the instance of ContainerLogger is sent
every message recieved by the other logger instances
In the case of FogLogger we have had to add additional messages
to deal with the Econ gem's requirements around logging
requests.
This failure manifests itself as a failure to validate
credentials on providers which use Fog when running in a
container.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527546