Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label has been deprecated and I need PR for day #16671

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Label has been deprecated and I need PR for day #16671

merged 1 commit into from
Dec 15, 2017

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Dec 15, 2017

Moving from nonsensical dialog labels to dialog names

@d-m-u
Copy link
Contributor Author

d-m-u commented Dec 15, 2017

@bdunne hi, happy friday :)

@miq-bot
Copy link
Member

miq-bot commented Dec 15, 2017

Checked commit d-m-u@d4aaae8 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@bdunne bdunne merged commit da44fe7 into ManageIQ:master Dec 15, 2017
@bdunne bdunne self-assigned this Dec 15, 2017
@bdunne bdunne added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 15, 2017
@d-m-u d-m-u deleted the dialog_name_label_update_thing_for_stats branch December 15, 2017 14:21
simaishi pushed a commit that referenced this pull request Dec 15, 2017
@bdunne @simaishi
Merge pull request #16671 from d-m-u/dialog_name_label_update_thing_f…
8c1003c 
…or_stats

Label has been deprecated and I need PR for day
(cherry picked from commit da44fe7)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 8c1003c1a4abe5370bb49ae129e2dc5797cdf731
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Fri Dec 15 09:07:16 2017 -0500

    Merge pull request #16671 from d-m-u/dialog_name_label_update_thing_for_stats
    
    Label has been deprecated and I need PR for day
    (cherry picked from commit da44fe75dc7fcc5820c5e23d33333cf311c6f9bb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

Assignees

@bdunne bdunne

Labels
gaprindashvili/backported lifecycle/provisioning lifecycle/services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-m-u @miq-bot @simaishi @bdunne