disconnect flag not respected in link_ems_inventory #16618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@borod108 please review |
agrare
reviewed
Dec 8, 2017
| ems.remove_all_children | ||
| else | ||
| elsif !root_id.nil? |
There was a problem hiding this comment.
How about just ems.remove_all_children if disconnect so we can leave the if/else conditions the same?
|
@pkliczewski can you add a test to catch this case? |
|
@agrare sure, will add a test |
|
Thanks! |
When new vm is created we use `save_ems_inventory_no_disconnect` where we set disconnect flag to `false`. It was not respected for all operations. Bug-Url: https://bugzilla.redhat.com/1518739
pkliczewski
force-pushed
the
disconnect_removal
branch
from
7375a2d
to
89b617d
Compare
|
Checked commit pkliczewski@89b617d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/ems_refresh/link_inventory.rb
|
agrare
approved these changes
Dec 12, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 14, 2017
disconnect flag not respected in link_ems_inventory (cherry picked from commit c2fb020) https://bugzilla.redhat.com/show_bug.cgi?id=1526042
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new vm is created we use
save_ems_inventory_no_disconnectwherewe set disconnect flag to
false. It was not respected for alloperations.
Bug-Url:
https://bugzilla.redhat.com/1518739