Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing model names into locale/en.yml #16604

Merged

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Dec 6, 2017

This should probably also land in Gaprindashvili, for the sake of generic objects: we do display these pretty model names in the UI when creating new GO definitions.

@miq-bot
Copy link
Member

miq-bot commented Dec 6, 2017

Checked commit mzazrivec@35c5a2b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@chessbyte chessbyte self-assigned this Dec 8, 2017
@chessbyte chessbyte merged commit 514ce3e into ManageIQ:master Dec 8, 2017
@chessbyte chessbyte added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 8, 2017
@mzazrivec mzazrivec deleted the add_missing_model_names_into_en_yml branch December 8, 2017 12:23
simaishi pushed a commit that referenced this pull request Dec 11, 2017
…_en_yml

Add missing model names into locale/en.yml
(cherry picked from commit 514ce3e)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 54831f6f30f764c334955cda75bcf711560c8435
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Fri Dec 8 07:04:14 2017 -0500

    Merge pull request #16604 from mzazrivec/add_missing_model_names_into_en_yml
    
    Add missing model names into locale/en.yml
    (cherry picked from commit 514ce3e31680d5f14afe5f863b82d3ca76ea14df)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants