Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy ems alert statuses when ems is destroyed #16592

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Destroy ems alert statuses when ems is destroyed #16592

merged 1 commit into from
Dec 11, 2017

Conversation

zeari
Copy link

@zeari zeari commented Dec 4, 2017

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1514928

@moolitayer @zgalor @cben Please review

@miq-bot add_label providers/containers

zgalor
zgalor approved these changes Dec 4, 2017
View reviewed changes
Copy link
Contributor

@zgalor zgalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

moolitayer
moolitayer approved these changes Dec 4, 2017
View reviewed changes
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2017

Checked commit zeari@88e89d6 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@cben
Copy link
Contributor

cben commented Dec 4, 2017

LGTM.
status already has dependent destroy for status actions.

@zeari
Copy link
Author

zeari commented Dec 7, 2017

@miq-bot add_label gapridashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2017

@zeari Cannot apply the following label because they are not recognized: gapridashvili/yes

@zeari
Copy link
Author

zeari commented Dec 7, 2017

@miq-bot add_label gaprindashvili/yes

@zeari
Copy link
Author

zeari commented Dec 7, 2017

@blomquisg @gtanzillo Please review

@gtanzillo gtanzillo self-assigned this Dec 11, 2017
@gtanzillo gtanzillo added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 11, 2017
@gtanzillo gtanzillo merged commit f62dae6 into ManageIQ:master Dec 11, 2017
simaishi pushed a commit that referenced this pull request Dec 12, 2017
@gtanzillo @simaishi
Merge pull request #16592 from zeari/fix_alert_delete
05bbdfe 
Destroy ems alert statuses when ems is destroyed
(cherry picked from commit f62dae6)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 05bbdfeeb972ac6071bb30dca15f08f9aceebcf7
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Dec 11 15:53:20 2017 -0500

    Merge pull request #16592 from zeari/fix_alert_delete
    
    Destroy ems alert statuses when ems is destroyed
    (cherry picked from commit f62dae6ec44b686d1842d117248e28d818c6b69a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

@moolitayer moolitayer moolitayer approved these changes

@zgalor zgalor zgalor approved these changes

Assignees

@gtanzillo gtanzillo

Labels
gaprindashvili/backported providers/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zeari @miq-bot @cben @simaishi @gtanzillo @moolitayer @zgalor