Looks like self is needed on PRODUCT_NAME and VERSION calls

[juliancheal]

Also making sure PRODUCT_NAME is also frozen.

In trying to get this Lenovo PR green ManageIQ/manageiq-providers-lenovo#96 we realised we should have kept the self. prefix to PRODUCT_NAME and VERSION in #16410

Otherwise you get

Vmdb::Appliance.USER_AGENT NameError: uninitialised constant Vmdb::Appliance::PRODUCT_NAME

/cc @Fryguy

[juliancheal]

@miq-bot assign @Fryguy

[miq-bot]

@juliancheal Cannot apply the following label because they are not recognized: bug gaprindashvili/yes core

[juliancheal]

@miq-bot add_label bug, gaprindashvili/yes, core

[miq-bot]

Checked commit juliancheal@3355662 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 781eb0254ce1939597139a4486d30dc8c52b1414
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Wed Nov 29 13:35:02 2017 -0500

    Merge pull request #16556 from juliancheal/fix_user_agent
    
    Looks like self is needed on PRODUCT_NAME and VERSION calls
    (cherry picked from commit eaa0a19f41b23be232efda0f6af9afec85f79d9a)

[juliancheal]

@simaishi Thanks 👍