Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in policy event details header #16513

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Fix typo in policy event details header #16513

merged 1 commit into from
Nov 22, 2017

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 21, 2017

Fix typo in details of policy event on timeline: s/Tagret/Target/

Fixes BUG 1515451

@tumido
Copy link
Member Author

tumido commented Nov 21, 2017

@miq-bot add_label bug, events

@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2017

Checked commit tumido@7742e2d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@abonas
Copy link
Member

abonas commented Nov 22, 2017

@miq-bot add-label providers/middleware
LGTM
@agrare who can merge this?

@agrare agrare self-assigned this Nov 22, 2017
@agrare agrare merged commit 7ed6dd1 into ManageIQ:master Nov 22, 2017
@abonas
Copy link
Member

abonas commented Nov 23, 2017

@miq-bot rm_label providers/middleware
@miq-bot add_label gaprindashvili/yes

@agrare agrare added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 23, 2017
simaishi pushed a commit that referenced this pull request Nov 27, 2017
@agrare @simaishi
Merge pull request #16513 from tumido/typo_tagret_on_timeline
60811cc 
Fix typo in policy event details header
(cherry picked from commit 7ed6dd1)

https://bugzilla.redhat.com/show_bug.cgi?id=1517823
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 60811cc286069beb6241982f1175319a40067dae
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Nov 22 07:57:24 2017 -0500

    Merge pull request #16513 from tumido/typo_tagret_on_timeline
    
    Fix typo in policy event details header
    (cherry picked from commit 7ed6dd191b464907bee0fad10108ed33053ef4d5)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517823

@GregP
Copy link
Contributor

GregP commented Apr 12, 2018

@miq-bot add_label fine/yes

Per duplicate BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1542962

simaishi pushed a commit that referenced this pull request Apr 16, 2018
@agrare @simaishi
Merge pull request #16513 from tumido/typo_tagret_on_timeline
790efa5 
Fix typo in policy event details header
(cherry picked from commit 7ed6dd1)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1567983
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 790efa50efc63d9a4a0e6b7926e8384161dec828
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Nov 22 07:57:24 2017 -0500

    Merge pull request #16513 from tumido/typo_tagret_on_timeline
    
    Fix typo in policy event details header
    (cherry picked from commit 7ed6dd191b464907bee0fad10108ed33053ef4d5)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1567983

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
@agrare @d-m-u
Merge pull request ManageIQ#16513 from tumido/typo_tagret_on_timeline
7b4e3c1 
Fix typo in policy event details header
(cherry picked from commit 7ed6dd1)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1567983
@tumido tumido deleted the typo_tagret_on_timeline branch June 26, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
bug core/events fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tumido @miq-bot @abonas @simaishi @GregP @agrare @chessbyte