Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am not wrong, you can move those three inherited factories within the
middleware_server
factory and then remove theparent => :middleware_server
attribute from each child factory definition.Here a bit of more context:
https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#inheritance
Do you think it worth to change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xeviknal I think the way it is done here in the PR is the same as the rest of miq does, so imo it is not worth to change it for consistency reasons. but I'd like to hear what @agrare thinks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abonas is right we (rightly or wrongly) follow this pattern, e.g. see the orchestration_stack factory https://github.com/ManageIQ/manageiq/blob/master/spec/factories/orchestration_stack.rb
👍 on this for consistency