-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workers can run log_status so ask for the right pid #16460
Conversation
If no argument is provided, processInfo will get the current process' memory information, which when run from a queue worker, will not be the server's pid.
Checked commit jrafanie@38b66e6 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Workers can run log_status so ask for the right pid (cherry picked from commit 974e360)
Gaprindashvili backport details:
|
@jrafanie Please add BZ link. |
Added link above @simaishi |
Workers can run log_status so ask for the right pid (cherry picked from commit 974e360) https://bugzilla.redhat.com/show_bug.cgi?id=1519987
Fine backport details:
|
Workers can run log_status so ask for the right pid (cherry picked from commit 974e360) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1519988
Euwe backport details:
|
Workers can run log_status so ask for the right pid (cherry picked from commit 974e360) https://bugzilla.redhat.com/show_bug.cgi?id=1519987
If no argument is provided, processInfo will get the current process'
memory information, which when run from a queue worker, will not be the
server's pid.
https://bugzilla.redhat.com/show_bug.cgi?id=1519953
When run on an appliance with a bloated MiqServer process:
Before (uses the current Process's memory information):
After:
@dmetzger57 @NickLaMuro don't trust any MiqServer.log_status log lines, they're most likely wrong.