Fixed named scope regression in MiqSchedule.with_prod_default_not_in #16349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need this one for the release. Waiting for travis. |
martinpovolny
approved these changes
Oct 30, 2017
|
This pull request is not mergeable. Please rebase and repush. |
|
@skateman : I tested the "merge conflict" feature, but ended up with 2 commits instead of one. Please, rebase. Other than the rebase, we are good and this can be merged. |
skateman
force-pushed
the
fix-scope-schedule
branch
from
bc17709
to
71c173c
Compare
martinpovolny
approved these changes
Oct 30, 2017
|
Checked commit skateman@71c173c with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the TreeBuilder the query should be
(prod_default != 'system' or prod_default is null)and not(prod_default != 'system' or prod_default is not null).To test this you'll need both #16348 and ManageIQ/manageiq-ui-classic#2564
Before:
After:
