Fix Compare Current and Desired queue arrays #16325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
juliancheal
changed the title
|
I'll fix stopping Amazon refresh workers in a follow up PR. |
juliancheal
force-pushed
the
fix_multi_ems_workers
branch
2 times, most recently
from
d489824
to
acfe2bb
Compare
Fryguy
reviewed
Oct 27, 2017
| @@ -114,6 +114,10 @@ def ems_id_from_queue_name(queue_name) | |||
| def ems_from_queue_name(queue_name) | |||
| ExtManagementSystem.find_by(:id => ems_id_from_queue_name(queue_name)) | |||
| end | |||
|
|
|||
| def compare_queues(current, desired) | |||
There was a problem hiding this comment.
Should this be a private method?
|
Yes I made it a private method at first and it didn't work. Then after making it public I realised I had it in the wrong part of the file (was in the other module). Forgot then to privatise again.
… On 27 Oct 2017, at 17:38, Jason Frey ***@***.***> wrote:
@Fryguy commented on this pull request.
In app/models/mixins/per_ems_worker_mixin.rb:
> @@ -114,6 +114,10 @@ def ems_id_from_queue_name(queue_name)
def ems_from_queue_name(queue_name)
ExtManagementSystem.find_by(:id => ems_id_from_queue_name(queue_name))
end
+
+ def compare_queues(current, desired)
Should this be a private method?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
* Flatten & sort arrays * Compare values return boolean. Changed `if current != desired` to unless method as compare_queues returns a boolean.
juliancheal
force-pushed
the
fix_multi_ems_workers
branch
from
acfe2bb
to
cb4b389
Compare
|
Checked commit juliancheal@cb4b389 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@Fryguy made the method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
if current != desiredtounlessmethod as compare_queuesreturns a boolean.