Apply dialog tags to VMs created during orchestration provisioning #16299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
reviewed
Oct 25, 2017
| tag_ids = provisioning_tag_ids | ||
| return if tag_ids.empty? | ||
|
|
||
| vm_ids = direct_vms.collect(&:id) |
There was a problem hiding this comment.
Although direct_vms and all_vms return the same, isn't all_vms more meaningful?
| tag_sequence = match[:sequence].to_i | ||
| value.scan(DIALOG_TAG_VALUE_REGEX).flatten if tag_sequence.zero? || tag_sequence == provision_sequence | ||
| end | ||
| end.compact.map!(&:to_i) |
There was a problem hiding this comment.
They don't need to be converted to integers, do they?
gmcculloug
force-pushed
the
orchestraion_provisioning_tags
branch
from
998c849
to
b05499b
Compare
|
@bzwei Updated based on your comments. |
bzwei
approved these changes
Oct 26, 2017
|
@mkanoor @tinaafitz Please review. Tests are green now. |
mkanoor
reviewed
Oct 27, 2017
| end | ||
| end | ||
|
|
||
| context `with a vm` do |
There was a problem hiding this comment.
@gmcculloug Should these be apostrophes or a back tick.
There was a problem hiding this comment.
Good catch, my markdown past haunts me. I'll clean up both, thanks.
mkanoor
reviewed
Oct 27, 2017
| context `with a vm` do | ||
| before { expect(service).to receive(:all_vms).and_return([vm]) } | ||
|
|
||
| context `with a single service and dialog tag options` do |
gmcculloug
force-pushed
the
orchestraion_provisioning_tags
branch
from
b05499b
to
195afd5
Compare
|
Checked commit gmcculloug@195afd5 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
mkanoor
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM Lifecycle provisioning (and associated service provisioning) allow users to select tags and those tags are automatically applied to the resulting VMs. Orchestration provisioning supports tag select, through service dialogs, but the resulting VMs do not have the tags applied as part of the post provisioning steps.
This PR uses the standard dialog field naming scheme (dialog_tag__) to determine which tags are applied to the created VMs.
For example:
dialog_tag_0_envwould apply the selected tag (or tags for multi-select tag categories) to all VMs created for a single service or bundle service provision request.dialog_tag_1_envtags would apply to VMs created during a single service provision or a service provisioned in a bundle with a provisioning order of 1.dialog_tag_2_envtags would only be applied to VMs that belong to a service that is part of a bundle and have a provisioning order of 2.Links [Optional]