Add hawkular admin tenant label to settings #16275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit https://github.com/elad661/manageiq/commit/93aa3f440b95b5d9db979f6a76608fd79c4b9f45 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compute -> Containers -> Providers -> Choose provider -> Monitoring -> Ad-hoc metrics
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1503541
ManageIQ/manageiq-ui-classic#2497
Add hawkular admin tenant label to settings, which together with ManageIQ/manageiq-ui-classic#2497 makes it look good in the UI.
Users of OpenShift can create custom tenants in the Hawkular database. The ad-hoc metrics page can handle some pre-defined names, but users can choose to define new ones. This PR adds an example of such setting, and the one in manageiq-ui-classic adds the code to support this kind of setting.
Before
After
Settings