Turn options into indifferent access #16254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement |
syncrou
approved these changes
Oct 20, 2017
|
@bzwei Please add some tests around this change. If we start using strings or symbols we will need a test in case this inadvertently gets removed. |
bzwei
force-pushed
the
options_with_indifferent_access
branch
from
afb97c3
to
efe4ee8
Compare
|
@gmcculloug I changed one of the tests to use string keys. It will fail if we remove the indifferent accessibility. |
|
Checked commit bzwei@efe4ee8 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code expects all options keys are symbols. We discovered symbols keys can cause troubles for serializing and deserializing. With the simple fix we now accept either symbol or string.