Remove legacy naming code from provisioning #16237
Conversation
Remove legacy provision naming code.
app/models/miq_provision/naming.rb
Outdated
| @@ -1,31 +1,20 @@ | |||
| module MiqProvision::Naming | |||
| extend ActiveSupport::Concern | |||
|
|
|||
| NAME_VIA_AUTOMATE = true | |||
| NAME_SEQUENCE_REGEX = /\$n\{(\d+)\}/ | |||
| SOURCE_IDENTIFIER = "provisioning" # a unique name for the source column in custom_attributes table | |||
|
|
|||
| module ClassMethods | |||
| def get_next_vm_name(prov_obj, determine_index = true) | |||
| unresolved_vm_name = nil | |||
There was a problem hiding this comment.
I don't think you need this assignment anymore either, right?
There was a problem hiding this comment.
Correct, I was initially limiting this to just the relevant changes as I am working on another refactoring of this code to support some new functionality.
It was hard to ignore this at the end of the method, but I'll add them if you prefer:
vm_name = get_vm_full_name(unresolved_vm_name, prov_obj, determine_index)
vm_name
There was a problem hiding this comment.
Heh, gotcha. I don't mind some cleanup in the same PR (in a separate commit!), but you can do whatever you wish!
gmcculloug
changed the title
|
@gmcculloug this brings back memories from almost a decade ago! |
gmcculloug
force-pushed
the
remove_legacy_provision_naming
branch
from
bfda4e7
to
0a0c980
Compare
|
Checked commits gmcculloug/manageiq@e5e142c~...0a0c980 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
gmcculloug
changed the title
|
✂️ 🔥 ✂️ 🔥 ✂️ 🔥 🍰 🍪 👏 🙇 😍 🎉 |
Remove legacy naming code from provisioning (cherry picked from commit 8636cc7) https://bugzilla.redhat.com/show_bug.cgi?id=1539752
|
This PR is needed in Fine branch to take a blocker PR #16897. Fine backport details: |
…sion_naming Remove legacy naming code from provisioning (cherry picked from commit 8636cc7) https://bugzilla.redhat.com/show_bug.cgi?id=1539752
The initial provisioning naming logic was stored in a file on disk so customers could easily modify it. A long long time ago this logic was moved into automate to better support multi-appliance configurations. (Yeah, that long ago.)
This change also removes a brakeman exception.