Don't support memcached in containers even if it is installed #16229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the monolithic image we will start memcached from the entrypoint without using systemd. The MiqMemcached code only uses systemd so that will break when we stop running systemd in the monolithic image. This will be fine in the other container images as we don't install memcached there.
|
Checked commit carbonin@3d3f716 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Oct 18, 2017
|
Merging while red because the failures are unrelated to this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the monolithic image we will start memcached from the entrypoint without using systemd. The MiqMemcached code only uses systemd so that will break when we stop running systemd in the monolithic image.
This will be fine in the other container images as we don't install memcached there.