-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use resources(VMs) also from all subtenants in chargeback reporting #16228
Merged
gtanzillo
merged 2 commits into
ManageIQ:master
from
lpichler:fix_use_subtree_of_tenants
Oct 19, 2017
Merged
Use resources(VMs) also from all subtenants in chargeback reporting #16228
gtanzillo
merged 2 commits into
ManageIQ:master
from
lpichler:fix_use_subtree_of_tenants
Oct 19, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
changed the title
[WIP] Use resources(VMs) also from all subtenants
[WIP] Use resources(VMs) also from all subtenants in chargeback reporting
Oct 18, 2017
We need to keep AR scope, existing code is counting with it.
lpichler
force-pushed
the
fix_use_subtree_of_tenants
branch
from
October 18, 2017 17:35
25e652c
to
c7c149a
Compare
lpichler
changed the title
[WIP] Use resources(VMs) also from all subtenants in chargeback reporting
Use resources(VMs) also from all subtenants in chargeback reporting
Oct 18, 2017
@miq-bot add_label bug, chargeback @gtanzillo specs added. |
- it was using before :tag as a filter - use parent to built hiearchy of tenants
lpichler
force-pushed
the
fix_use_subtree_of_tenants
branch
from
October 18, 2017 17:38
c7c149a
to
bb48d57
Compare
Checked commits lpichler/manageiq@02af2b5~...bb48d57 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
gtanzillo
approved these changes
Oct 19, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
simaishi
pushed a commit
that referenced
this pull request
Nov 13, 2017
Use resources(VMs) also from all subtenants in chargeback reporting (cherry picked from commit 323f1a9) https://bugzilla.redhat.com/show_bug.cgi?id=1510698
Fine backport details:
|
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…nants Use resources(VMs) also from all subtenants in chargeback reporting (cherry picked from commit 323f1a9) https://bugzilla.redhat.com/show_bug.cgi?id=1510698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in chargeback for vms report, in filter tab, when filter by tenant has been selected it did not take VMs from sub tenants for filtering in chargeback report.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1498027
@miq-bot assign @gtanzillo