Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resources(VMs) also from all subtenants in chargeback reporting #16228

Merged
merged 2 commits into from
Oct 19, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Oct 18, 2017

in chargeback for vms report, in filter tab, when filter by tenant has been selected it did not take VMs from sub tenants for filtering in chargeback report.

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1498027

@miq-bot assign @gtanzillo

@lpichler lpichler changed the title [WIP] Use resources(VMs) also from all subtenants [WIP] Use resources(VMs) also from all subtenants in chargeback reporting Oct 18, 2017
@miq-bot miq-bot added the wip label Oct 18, 2017
We need to keep AR scope, existing code
is counting with it.
@lpichler lpichler changed the title [WIP] Use resources(VMs) also from all subtenants in chargeback reporting Use resources(VMs) also from all subtenants in chargeback reporting Oct 18, 2017
@miq-bot miq-bot removed the wip label Oct 18, 2017
@lpichler
Copy link
Contributor Author

@miq-bot add_label bug, chargeback

@gtanzillo specs added.

- it was using before :tag as a filter
- use parent to built hiearchy of tenants
@miq-bot
Copy link
Member

miq-bot commented Oct 18, 2017

Checked commits lpichler/manageiq@02af2b5~...bb48d57 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@gtanzillo gtanzillo added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 19, 2017
@gtanzillo gtanzillo merged commit 323f1a9 into ManageIQ:master Oct 19, 2017
@lpichler lpichler deleted the fix_use_subtree_of_tenants branch October 23, 2017 15:59
simaishi pushed a commit that referenced this pull request Nov 13, 2017
Use resources(VMs) also from all subtenants in chargeback reporting
(cherry picked from commit 323f1a9)

https://bugzilla.redhat.com/show_bug.cgi?id=1510698
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit c133d546f453c6a484720d02fccc65e3d13ad639
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Thu Oct 19 11:07:10 2017 -0400

    Merge pull request #16228 from lpichler/fix_use_subtree_of_tenants
    
    Use resources(VMs) also from all subtenants in chargeback reporting
    (cherry picked from commit 323f1a9b3dd7263c71b4a813e38ae52e5baa45f0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510698

@lpichler
Copy link
Contributor Author

@simaishi it seem that I can change fine/yes

@miq-bot add_label fine/backported
@miq-bot remove_label fine/yes

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…nants

Use resources(VMs) also from all subtenants in chargeback reporting
(cherry picked from commit 323f1a9)

https://bugzilla.redhat.com/show_bug.cgi?id=1510698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants