Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep full model name when parsing expression with tag #16211

Merged
merged 4 commits into from
Oct 19, 2017
Merged

Keep full model name when parsing expression with tag #16211

merged 4 commits into from
Oct 19, 2017

Commits on Oct 17, 2017

  1. keep full model name when parsing MiqExpression::Tag. 

    https://bugzilla.redhat.com/show_bug.cgi?id=1501333
    @yrudman
    yrudman committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    071592a View commit details
    Browse the repository at this point in the history

  2. added test for MiqExpression::Tag.parse to check that full model retu… 

    …rned
    @yrudman
    yrudman committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    450c384 View commit details
    Browse the repository at this point in the history

  3. limit number of '::' when parsing model name. It will prevent from in… 

    …finity loop inside regex when parsing strings like 'ManageIQ::Providers::CloudManagermanaged-se'
    @yrudman
    yrudman committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    b19567a View commit details
    Browse the repository at this point in the history

  4. added test case with malformed tag expression for 'MiqExpression::Tag… 

    ….parse'
    @yrudman
    yrudman committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    1ef3fb0 View commit details
    Browse the repository at this point in the history