Add allowed_subnets for scvmm provisioning

[agrare]

Allow subnet selection for SCVMM provisioning

Depends on:

• SCVMM Networking Enhancements manageiq-providers-scvmm#19
• Handle vm_networks and subnets in cloning manageiq-providers-scvmm#27

Subnets dropdown:

Logical networks and VM Networks:

[bronaghs]

Hi @agrare
I am wondering if this is generic enough to remain here or should this be moved to the SCVMM subclass here ?

[agrare]

@bronaghs I went back and forth on that myself and I could still go either way. Currently it will only be shown for SCVMM but it is generic enough to work for any provider if/when they add subnet support which is why I had it here.

[bronaghs]

Thats fine by me. We can always move it in the future if we have to.

[bronaghs]

This is no longer a wip, right?

[bronaghs]

@miq-bot assign @blomquisg

[agrare]

@bronaghs I still need to filter the subnets and vlans if the other is selected and update the name for vm_networks to include the parent lan

[agrare]

@gmcculloug can you or @lfu help review the changes?
cc @bronaghs @djberg96 this should be ready now

The biggest nuisance is that if there is only one subnet it is auto-selected, not sure if I need to change that here or in the UI pr.

[gmcculloug]

@agrare Add :auto_select_single: false to the dialog field to avoid the auto-select issue.

Example: https://github.com/ManageIQ/manageiq/blob/master/product/dialogs/miq_dialogs/miq_provision_vmware_dialogs_template.yaml#L158

[agrare]

❤️ thanks @gmcculloug

[agrare]

I moved the bulk of the vlan and subnet handling into the scvmm provision_workflow because changing the lan key to uid_ems could break other providers that rely on it being the name.

This is moved here ManageIQ/manageiq-providers-scvmm#27

[gmcculloug]

This method will only be called by a dialog that defines the method name in :values_from on a dialog field and the subclassed provider workflow would include the method.

If there is common code that all, or most, workflows share it would be alright to include it here, but this not needed.

[agrare]

👍 removed

[gmcculloug]

We chopped plenty out of this PR, don't want to push my luck. 👍

[lfu]

What happen to :auto_select_single: false? Do we still want to avoid the auto-select issue?

[agrare]

Ah good catch @lfu I mistakenly dropped that commit

[blomquisg]

@agrare we're still waiting on ManageIQ/manageiq-providers-scvmm#27 ?

[agrare]

@blomquisg correct, it was blocked by ManageIQ/manageiq-providers-scvmm#29 which was just merged.
Need to re-test ManageIQ/manageiq-providers-scvmm#27 now.

[miq-bot]

Checked commit agrare@f5f85aa with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

[agrare]

@gmcculloug @blomquisg all dependent PRs have been merged can you take a look?