Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ScanResult model and ContainerImage has_one #15967

Merged

Conversation

enoodle
Copy link

@enoodle enoodle commented Sep 13, 2017

together with ManageIQ/manageiq-schema#57 This will add the model LastScanResult and will also add one of these to ContainerImage.

@roliveri
Copy link
Member

@enoodle This needs to be merged after ManageIQ/manageiq-schema#57 right?

@enoodle enoodle changed the title adding LastScanResult model and ContainerImage has_one [WIP] adding LastScanResult model and ContainerImage has_one Sep 19, 2017
@enoodle
Copy link
Author

enoodle commented Sep 19, 2017

@roliveri right. I think this will change while we develop
ManageIQ/manageiq-schema#57 more so I changed this to WIP

@miq-bot miq-bot added the wip label Sep 19, 2017
@enoodle enoodle force-pushed the add_last_scan_result_to_container_image branch from e38b043 to 703b29f Compare September 25, 2017 13:41
@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2017

Checked commit enoodle@703b29f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy Fryguy changed the title [WIP] adding LastScanResult model and ContainerImage has_one [WIP] adding ScanResult model and ContainerImage has_one Sep 28, 2017
@Fryguy
Copy link
Member

Fryguy commented Sep 28, 2017

Migration is merged...can you unWIP?

@enoodle enoodle changed the title [WIP] adding ScanResult model and ContainerImage has_one adding ScanResult model and ContainerImage has_one Sep 29, 2017
@miq-bot miq-bot removed the wip label Sep 29, 2017
@enoodle
Copy link
Author

enoodle commented Oct 3, 2017

ping @Fryguy

@enoodle
Copy link
Author

enoodle commented Oct 15, 2017

ping @Fryguy This is needed by ManageIQ/manageiq-providers-kubernetes#100 to complete RFE. PTAL

@Loicavenel
Copy link

@Fryguy Could you help here!!

@Fryguy Fryguy merged commit 029eefc into ManageIQ:master Oct 23, 2017
@Fryguy Fryguy added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants