Add Ansible Playbook custom button type #15874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalis
force-pushed
the
add_playbook_custom_button_type
branch
from
bcc1368
to
7105cbd
Compare
|
Checked commit lgalis@7105cbd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lgalis
changed the title
|
@miq-bot add_label enhancement, fine/no |
Fryguy
reviewed
Aug 30, 2017
| TYPES = { "default" => "Default", | ||
| "ansible_playbook" => "Ansible Playbook"}.freeze | ||
|
|
||
| PLAYBOOK_METHOD = "Order_Ansible_Playbook".freeze |
There was a problem hiding this comment.
|
@Fryguy Can this be merged? |
|
I just find it really strange that there's a hardcoded method name the shared/generic/common CustomButton model. If we are introducing types of custom buttons, we may want to go STI eventually I'll merge now anyway though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Ansible Playbook custom button type
Links
https://www.pivotaltracker.com/story/show/148248347