Fail with descriptive message when no EMS #15807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmcculloug please review |
gmcculloug
approved these changes
Aug 14, 2017
syncrou
suggested changes
Aug 14, 2017
app/models/miq_provision_request.rb
Outdated
| @@ -29,6 +29,10 @@ def self.request_task_class_from(attribs) | |||
| vm_or_template = VmOrTemplate.find_by(:id => source_id) | |||
| raise MiqException::MiqProvisionError, "Unable to find source Template/Vm with id [#{source_id}]" if vm_or_template.nil? | |||
|
|
|||
| if vm_or_template.ext_management_system.nil? | |||
There was a problem hiding this comment.
I think I would like this better if we pulled both checks (line 30 and line 32) into a single method. Since we check for both a template and with this change an ems it makes sense to consolidate the code that in either case can raise the same exception.
There was a problem hiding this comment.
I've extracted it into a method to retrieve the vm/template or raise an exception if failed to.
masayag
force-pushed
the
fail_when_vm_or_template_has_no_ems
branch
from
7e599b6
to
a0dcf2a
Compare
gmcculloug
reviewed
Aug 15, 2017
app/models/miq_provision_request.rb
Outdated
|
|
||
| via = MiqRequestMixin.get_option(:provision_type, nil, attribs['options']) | ||
| vm_or_template.ext_management_system.class.provision_class(via) | ||
| end | ||
|
|
||
| def self.fetch_vm_or_template_for_provision!(source_id) |
There was a problem hiding this comment.
Suggest renaming to self.source_vm_or_template!
When no EMS is associated with a VM or template, the provision request fails with a non-descriptive message. Such case might happen when the VM or template were removed from the provider side, but still exist as archived on vmdb. The purpose of the PR is to provide a clear failure message when there is no EMS. https://bugzilla.redhat.com/show_bug.cgi?id=1471124
masayag
force-pushed
the
fail_when_vm_or_template_has_no_ems
branch
from
a0dcf2a
to
92ed48a
Compare
|
Checked commit masayag@92ed48a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 15, 2017
…o_ems Fail with descriptive message when no EMS (cherry picked from commit fa24dff) https://bugzilla.redhat.com/show_bug.cgi?id=1481845
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…te_has_no_ems Fail with descriptive message when no EMS (cherry picked from commit fa24dff) https://bugzilla.redhat.com/show_bug.cgi?id=1481845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no EMS is associated with a VM or template, the provision request
fails with a non-descriptive message. Such case might happen when the VM
or template were removed from the provider side, but still exist as
archived on vmdb. The purpose of the PR is to provide a clear failure
message when there is no EMS.
https://bugzilla.redhat.com/show_bug.cgi?id=1471124