Fix Core Refresher if there is no ems_vmware setting #15690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no prototype.ems_refresh setting currently the Ems Refresh Core worker will raise an exception.
|
Checked commit agrare@b4a17fa with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
deleted the
fix_ems_refresh_core_worker_no_update_driven_refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until ManageIQ/manageiq-providers-vmware#76 is merged there will not be a
Settings.prototype.ems_vmwareso currently the core refresh worker will raise an exception when starting up.cc @carbonin