Allow MiqWorker.required_roles to be a lambda #15522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow for more complex deployment configurations allow the required_roles property of MiqWorker to be a lambda
agrare
force-pushed
the
allow_miq_worker_required_roles_lambda
branch
from
1e20059
to
0d1eca1
Compare
|
Checked commit agrare@0d1eca1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Nice improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for more complex deployment configurations allow the required_roles property of MiqWorker to be a lambda similar to
MiqWorker.workersThis will allow us to change the roles for which a worker will start depending on config, for example start the
MiqVimBrokerWorkerfor theems_inventoryrole only if we aren't using a collector/persister split.