Only run the setup playbook the first time we start embedded ansible #15225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
requested changes
May 25, 2017
|
@miq-bot add_label blocker |
carbonin
force-pushed
the
dont_run_setup_script_every_time
branch
2 times, most recently
from
698869e
to
d477f2c
Compare
It needs to run once to put files in place and such, but it restarts services in a way that could cause us to operate on a running stack only to have it restart from under us. This change makes us only run the setup playbook once so the chance of hitting this kind of issue should be much smaller. This effectively combines the .configure and .start methods so that we detect when we are in the first configuration state vs just starting up the services. https://bugzilla.redhat.com/show_bug.cgi?id=1455063
carbonin
force-pushed
the
dont_run_setup_script_every_time
branch
from
d477f2c
to
0ec1271
Compare
|
Checked commits carbonin/manageiq@060a0c4~...0ec1271 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
jrafanie
approved these changes
May 25, 2017
simaishi
pushed a commit
that referenced
this pull request
May 25, 2017
Only run the setup playbook the first time we start embedded ansible (cherry picked from commit 1fa4663) https://bugzilla.redhat.com/show_bug.cgi?id=1455618
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs to run once to put files in place and such, but it restarts services in a way that could cause us to operate on a running stack only to have it restart from under us.
This change makes us only run the setup playbook once so the chance of hitting this kind of issue should be much smaller.
This effectively combines the
.configureand.startmethods so that we detect when we are in the first configuration state vs just starting up the services.https://bugzilla.redhat.com/show_bug.cgi?id=1455063
/cc @ghjm @matburt