Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ActiveRecord::Base for connection info #15019

Conversation

NickLaMuro
Copy link
Member

Don't use ApplicationRecord for this purpose since it might not be defined, and ActiveRecord::Base.connection is what is used everywhere else in this class.

Another support PR for #14916

Links

Not ApplicationRecord, since it might not be defined, and
ActiveRecord::Base.connection is what is used everywhere else in this
class.
@miq-bot
Copy link
Member

miq-bot commented May 5, 2017

Checked commit NickLaMuro@1c28035 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@chessbyte chessbyte self-assigned this May 8, 2017
@chessbyte chessbyte merged commit 443404f into ManageIQ:master May 8, 2017
@chessbyte chessbyte added this to the Sprint 60 Ending May 8, 2017 milestone May 8, 2017
NickLaMuro added a commit to NickLaMuro/manageiq that referenced this pull request May 9, 2017
This is a commit to help implement the features implemented in the
following PRs:

    ManageIQ#14953
    ManageIQ#14967
    ManageIQ#15014
    ManageIQ#15018
    ManageIQ#15019
    ManageIQ#15020

Meant to illustrate how they will eventually be used in this PR, and
show how they will be implemented when they are merged into master.
The prior commits to this one are left in place to show before and
after, but this and those will be removed in the final iteration of this
pull request, and only the necessary changes needed to implement this in
the Rake tasks will be part of this PR.

Applying all of the changes for this PR was done as follows:

    $ git apply <(curl -L ManageIQ#14953)
    $ git apply <(curl -L ManageIQ#14967)
    $ git apply <(curl -L ManageIQ#15014)
    $ git apply <(curl -L ManageIQ#15018)
    $ git apply <(curl -L ManageIQ#15019)
    $ git apply <(curl -L ManageIQ#15020)

And then with some extra changes on top of that:

* Making use of `Miq.env` and `Miq.root` where relevant
* Implementing the modulularized PRs in the `tools/utils/mini_*.rb`
  files where relavant
* Various bug fixes (though some seem like they shouldn't be there...)

Again, this is meant as a demonstration commit to show the before and
after while this is still a POC.  Once the necessary pieces are in place
on master to make this commit irrelevant, it will be rebased out.  It
may also change over time as this PR is worked on further.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants