Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use human friendly names in task names and notifications for Tower CUD operations #14977

Merged
merged 2 commits into from
May 8, 2017

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented May 3, 2017

A further improvement on top of #14656 for https://bugzilla.redhat.com/show_bug.cgi?id=1439203
and for https://bugzilla.redhat.com/show_bug.cgi?id=1448081 as well.

Use human friendly names instead of the class names in task names and keep the notification message brief and user friendly.

Before:

e.g.

  • User would see in task:Creating ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationScriptSource name=My repo
  • User would see in notification: The operation ConfigurationScriptSource update_in_provider {:name=>..... create_on.....} completed successully

Now:

e.g.

  • User would see: Creating Ansible Tower Project (name=My repo)
  • User would see in notification: The operation Ansible Tower Project update (name=My Repo, manager_ref=1) on Tower(manager_id=10000000) completed successfully.
  • The detail parameter hash (sans secrete) would be logged into logs

@miq-bot add_labels bug, providers/ansible_tower

@miq-bot
Copy link
Member

miq-bot commented May 4, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented May 4, 2017

Checked commits jameswnl/manageiq@f30670a~...d2636d3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 0 offenses detected
Everything looks fine. 🏆

@jameswnl jameswnl changed the title Use human friendly names in task names Use human friendly names in task names and notifications for Tower CUD operations May 4, 2017
@miq-bot
Copy link
Member

miq-bot commented May 8, 2017

@chrispy1 unrecognized command 'blocker', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@chrispy1
Copy link

chrispy1 commented May 8, 2017

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label May 8, 2017
@chrispy1
Copy link

chrispy1 commented May 8, 2017

@miq-bot add_label fine/yes

@blomquisg blomquisg merged commit d7c3613 into ManageIQ:master May 8, 2017
@blomquisg blomquisg added this to the Sprint 60 Ending May 8, 2017 milestone May 8, 2017
@jameswnl jameswnl deleted the task-name branch May 8, 2017 23:14
simaishi pushed a commit that referenced this pull request May 9, 2017
Use human friendly names in task names and notifications for Tower CUD operations
(cherry picked from commit d7c3613)

https://bugzilla.redhat.com/show_bug.cgi?id=1440573
https://bugzilla.redhat.com/show_bug.cgi?id=1449223
@simaishi
Copy link
Contributor

simaishi commented May 9, 2017

Fine backport details:

$ git log -1
commit dc560d8f354496c24cd93543f1be7c90f8690d76
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Mon May 8 17:31:24 2017 -0400

    Merge pull request #14977 from jameswnl/task-name
    
    Use human friendly names in task names and notifications for Tower CUD operations
    (cherry picked from commit d7c36131c9a824aae2f3741c42d7632a09f9743b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1440573
    https://bugzilla.redhat.com/show_bug.cgi?id=1449223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants