-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert previous changes adding notification to finish retirement. #14955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is not mergeable. Please rebase and repush. |
Since not all objects have user/tenant information, we're going to create a content PR to add notifications to Automate methods where that information is available. https://bugzilla.redhat.com/show_bug.cgi?id=1446466
tinaafitz
force-pushed
the
fix_finish_retirement
branch
from
May 1, 2017 20:11
ba5a6ef
to
93af270
Compare
@miq-bot add-label bug, retirement, services |
miq-bot
added
bug
lifecycle/retirement
lifecycle/services
and removed
unmergeable
labels
May 1, 2017
Checked commit tinaafitz@93af270 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@tinaafitz Please link back here when you have the content PR. |
simaishi
pushed a commit
that referenced
this pull request
May 2, 2017
Revert previous changes adding notification to finish retirement. (cherry picked from commit d1e5d88) https://bugzilla.redhat.com/show_bug.cgi?id=1447367
Fine backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since not all objects have user/tenant information, we're going
to create a content PR to add notifications to Automate methods where
that information is available.
https://bugzilla.redhat.com/show_bug.cgi?id=1446466