Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert previous changes adding notification to finish retirement. #14955

Merged
merged 1 commit into from
May 2, 2017

Conversation

tinaafitz
Copy link
Member

Since not all objects have user/tenant information, we're going
to create a content PR to add notifications to Automate methods where
that information is available.

https://bugzilla.redhat.com/show_bug.cgi?id=1446466

@miq-bot
Copy link
Member

miq-bot commented May 1, 2017

This pull request is not mergeable. Please rebase and repush.

Since not all objects have user/tenant information, we're going
to create a content PR to add notifications to Automate methods where
that information is available.

https://bugzilla.redhat.com/show_bug.cgi?id=1446466
@tinaafitz
Copy link
Member Author

@miq-bot add-label bug, retirement, services

@miq-bot
Copy link
Member

miq-bot commented May 1, 2017

Checked commit tinaafitz@93af270 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks fine. 🍪

@gmcculloug
Copy link
Member

@tinaafitz Please link back here when you have the content PR.

@tinaafitz
Copy link
Member Author

@gmcculloug gmcculloug merged commit d1e5d88 into ManageIQ:master May 2, 2017
@gmcculloug gmcculloug added this to the Sprint 60 Ending May 8, 2017 milestone May 2, 2017
simaishi pushed a commit that referenced this pull request May 2, 2017
Revert previous changes adding notification to finish retirement.
(cherry picked from commit d1e5d88)

https://bugzilla.redhat.com/show_bug.cgi?id=1447367
@simaishi
Copy link
Contributor

simaishi commented May 2, 2017

Fine backport details:

$ git log -1
commit b8adb435b9ee436830ede833b2fd6a4ec3fd9d4f
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue May 2 08:37:02 2017 -0400

    Merge pull request #14955 from tinaafitz/fix_finish_retirement
    
    Revert previous changes adding notification to finish retirement.
    (cherry picked from commit d1e5d88f5ec5b922adf551e7e2c0bd3d5421fb22)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants