Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a notification for when the embedded ansible role is activated #14867

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Add a notification for when the embedded ansible role is activated #14867

merged 1 commit into from
Apr 25, 2017

Conversation

carbonin
Copy link
Member

This allows us to bookend the possibly long-running process of configuring and starting embedded ansible on a server.

The first notification will get sent as soon as the worker is started on a server and the other will get sent as soon as the embedded ansible service is up and running.

https://bugzilla.redhat.com/show_bug.cgi?id=1444852

@carbonin
Add a notification for when the embedded ansible role is activated
5160436 
This allows us to bookend the possibly long-running process
of configuring and starting embedded ansible on a server.

The first notification will get sent as soon as the worker is
started on a server and the other will get sent as soon as the
embedded ansible service is up and running.

https://bugzilla.redhat.com/show_bug.cgi?id=1444852
@carbonin carbonin requested a review from jrafanie April 24, 2017 21:15
@carbonin
Copy link
Member Author

screenshot from 2017-04-24 17-00-52

@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2017

Checked commit carbonin@5160436 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

jrafanie
jrafanie approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@jrafanie jrafanie merged commit 7d91d8b into ManageIQ:master Apr 25, 2017
@jrafanie jrafanie added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 25, 2017
@carbonin carbonin deleted the add_notification_for_embedded_ansible_role_start branch May 18, 2017 17:12
simaishi pushed a commit that referenced this pull request Jun 2, 2017
@jrafanie @simaishi
Merge pull request #14867 from carbonin/add_notification_for_embedded…
70df9b7 
…_ansible_role_start

Add a notification for when the embedded ansible role is activated
(cherry picked from commit 7d91d8b)

https://bugzilla.redhat.com/show_bug.cgi?id=1458356
@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2017

Fine backport details:

$ git log -1
commit 70df9b70b9b5a0787cdefa052394023e1ce6d333
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Tue Apr 25 10:48:32 2017 -0400

    Merge pull request #14867 from carbonin/add_notification_for_embedded_ansible_role_start
    
    Add a notification for when the embedded ansible role is activated
    (cherry picked from commit 7d91d8b7965ae9290d65e97fae9b3b5ebc8b5b76)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels
bug core/workers fine/backported providers/automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carbonin @miq-bot @simaishi @jrafanie @Fryguy