Refactor start_clone method and break up powershell functions #14842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djberg96 still having the refresh issue 😞 |
Ensure methods return a WinRM::Output object. Explicitly require winrm. Update spec to reflect returned object change.
|
Checked commit https://github.com/djberg96/manageiq/commit/8fa3c6bba9db263e335caa7e2cc5e65d4abc706d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
djberg96
changed the title
|
@jteehan @skateman This should be good to go. You can copy these files over, restart your app and then put it in debug mode to get full output. For testing I deliberately tried to create a non-HA VM on an HA cluster (which failed with the expected message), tried to create an HA VM on "C:/" (which failed with the expected message) and finally tried to create an HA VM on an HA cluster (which succeeded as expected). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where an invalid provisioning attempt could fail. Instead of a helpful error message, users are getting an obscure JSON parsing error.
What is essentially happening is that the call to
New-SCVirtualMachineinside thebuild_ps_scriptis failing, with the result that the method returns an empty string because there's no error checking. When JSON then tries to parse an empty string, it bombs.This PR splits the powershell functions into two separate calls, and we check the results of the first one before moving onto the second.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1441319