Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group chargeback with unknown image under 'unknown image' #14816

Merged
merged 1 commit into from
Apr 20, 2017
Merged

group chargeback with unknown image under 'unknown image' #14816

merged 1 commit into from
Apr 20, 2017

Conversation

zeari
Copy link

@zeari zeari commented Apr 19, 2017 •
edited
Loading

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1442158
same as #14811. containers without an identifiable image will grouped under "Unknown image" in Chargeback for container images reports
screencapture-localhost-3000-report-explorer-1492607823456

@gtanzillo @lpichler @isimluk Please review
cc @simon3z

@zeari
Copy link
Author

zeari commented Apr 19, 2017

@lpichler this works even with labels as columns.

@miq-bot
Copy link
Member

miq-bot commented Apr 19, 2017

Checked commit zeari@c541d66 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@isimluk isimluk self-assigned this Apr 20, 2017
isimluk
isimluk approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@isimluk isimluk added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 20, 2017
@isimluk isimluk added euwe/yes and removed euwe/no labels Apr 20, 2017
@isimluk isimluk merged commit 993774e into ManageIQ:master Apr 20, 2017
@isimluk
Copy link
Member

isimluk commented Apr 20, 2017

Thanks Ari!

simaishi pushed a commit that referenced this pull request Apr 20, 2017
@isimluk @simaishi
Merge pull request #14816 from zeari/fix_nil_images_in_chargeback
71fa007 
group chargeback with unknown image under 'unknown image'
(cherry picked from commit 993774e)

https://bugzilla.redhat.com/show_bug.cgi?id=1444038
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 71fa007377196b7a97c941c79692d8c049df129d
Author: Šimon Lukašík <isimluk@fedoraproject.org>
Date:   Thu Apr 20 10:00:47 2017 +0200

    Merge pull request #14816 from zeari/fix_nil_images_in_chargeback
    
    group chargeback with unknown image under 'unknown image'
    (cherry picked from commit 993774e1eb0d36a800ea60d7ed04eb1be2b38c8f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1444038

simaishi pushed a commit that referenced this pull request Apr 26, 2017
@isimluk @simaishi
Merge pull request #14816 from zeari/fix_nil_images_in_chargeback
d1ccf5c 
group chargeback with unknown image under 'unknown image'
(cherry picked from commit 993774e)

https://bugzilla.redhat.com/show_bug.cgi?id=1444041
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit d1ccf5c5c50dd80d39ac14241a38827a6a23673d
Author: Šimon Lukašík <isimluk@fedoraproject.org>
Date:   Thu Apr 20 10:00:47 2017 +0200

    Merge pull request #14816 from zeari/fix_nil_images_in_chargeback
    
    group chargeback with unknown image under 'unknown image'
    (cherry picked from commit 993774e1eb0d36a800ea60d7ed04eb1be2b38c8f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1444041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isimluk isimluk isimluk approved these changes

Assignees

@isimluk isimluk

Labels
bug core/chargeback euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeari @miq-bot @isimluk @simaishi