return correct custom_attributes href

[jntullo]

Performing an action, such as edit on custom_attributes returns an href that does not exist:

https://<address>/api/custom_attributes/:attribute_id

Custom attributes is not a collection and results in a not found when attempting to retrieve that object.

It should return an href with reference to the subcollection that is a custom attribute of.

Update: same issue was happening with tenant_quotas - added a spec to verify fix helped.

@miq-bot add_label wip, api, bug
@miq-bot assign @abellotti

[jntullo]

@miq-bot remove_label wip

[abellotti]

Hi @jntullo I think normalize_href can simply be the following:

def normalize_href(type, value)
  type.to_s == @req.subcollection ? subcollection_href(type, value) : collection_href(type, value)
end

[jntullo]

@abellotti yup, thanks! 😄

[miq-bot]

Checked commits jntullo/manageiq@9c77b3a~...6c2adb7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍰

[abellotti]

Thanks @jntullo for updating and fixing this bug 😍 will merge when 🍏