Avoid dozens of extra selects in seed_default_events #14722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isimluk
force-pushed
the
speed-up-miq_event_definition-seeds-2
branch
2 times, most recently
from
4bf290c
to
8fdcefe
Compare
lpichler
reviewed
Apr 11, 2017
app/models/miq_event_definition.rb
Outdated
| @@ -123,6 +123,7 @@ def self.seed | |||
| end | |||
|
|
|||
| def self.seed_default_events | |||
| event_sets = MiqEventDefinitionSet.all.group_by(&:name) | |||
There was a problem hiding this comment.
isn't it operation on Array ?
what about to use sql ?
MiqEventDefinitionSet.group(:name)
There was a problem hiding this comment.
agh yes, I am sorry, it is not same, 😳 please ignore my comment
Fryguy
reviewed
Apr 11, 2017
app/models/miq_event_definition.rb
Outdated
| @@ -123,6 +123,7 @@ def self.seed | |||
| end | |||
|
|
|||
| def self.seed_default_events | |||
| event_sets = MiqEventDefinitionSet.all.group_by(&:name) | |||
There was a problem hiding this comment.
Is .index_by a better choice than .group_by ? Especially since you are doing a .first below?
There was a problem hiding this comment.
Amended. Great suggestion! Thanks!
and use common before section.
before calling seed_default_events, that will enable us to be more strict within the method -> more validations for db/fixtures Fail early, fail fast.
MiqEventDefinitionSet is static union. It is inefficient to use multiple
selects instead of a single one.
On my system `100.times { MiqEventDefinition.seed_default_events }`
gives
:gear: | rows | selects | time | %
------ | ----- | ------- | ---- | ---
Before | 16900 | 16900 | 204s | 100%
After | 1300 | 100 | 93s | 45%
isimluk
force-pushed
the
speed-up-miq_event_definition-seeds-2
branch
from
8fdcefe
to
76d4220
Compare
|
Checked commits isimluk/manageiq@0699939~...76d4220 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiqEventDefinitionSet is static union. It is inefficient to use multiple selects instead of a single one.
On my system
100.times { MiqEventDefinition.seed_default_events }gives