Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parent/child relationships to VmOrTemplate #14639

Merged
merged 1 commit into from
Apr 5, 2017
Merged

add parent/child relationships to VmOrTemplate #14639

merged 1 commit into from
Apr 5, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Apr 4, 2017

Parent / Child relationships need to be accessible via the API without interfering with existing functionality in RelationshipMixin as mentioned here.

With these relationships exposed through the API, the user will be able to edit the parent/child relationships

@miq-bot add_label enhancement
@miq-bot assign @gtanzillo
cc: @abellotti

Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jntullo jntullo mentioned this pull request Apr 5, 2017
@abellotti
Copy link
Member

👍 Thanks @jntullo for the update.

@miq-bot
Copy link
Member

miq-bot commented Apr 5, 2017

Checked commit jntullo@0b88426 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 5, 2017
@gtanzillo gtanzillo merged commit 76e1960 into ManageIQ:master Apr 5, 2017
@jntullo jntullo deleted the enhancement/parent_child_relationships branch November 28, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants