Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds physical_server methods to be used by miq-ui #14552

Merged
merged 2 commits into from
Apr 17, 2017
Merged

Adds physical_server methods to be used by miq-ui #14552

merged 2 commits into from
Apr 17, 2017

Conversation

odravison
Copy link
Contributor

@odravison odravison commented Mar 28, 2017 •
edited
Loading

  1. Some changes, such as:
  • Adding VendorTypes to physical_server
  • Adding MiqPolicyMixin
  • Implementation of hook method has_compliance_policies?
  • Implementation of method label_for_vendor

All this changes is in physical_server model

@odravison odravison mentioned this pull request Mar 28, 2017
Closed
@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2017

Checked commits odravison/manageiq@c713fe0~...72f61a1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/models/physical_server.rb

@odravison
Copy link
Contributor Author

This line 24, col 7 that miq-bot is point to, is a default method used by others models. Cannot be modified.

@odravison
Copy link
Contributor Author

@miq-bot add_reviewer @blomquisg @Fryguy

@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2017

@odravison unrecognized command 'add_reviewer', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2017

@odravison 'blomquisg Fryguy' is an invalid assignee, ignoring...

@odravison
Copy link
Contributor Author

@miq-bot assign @Fryguy

@chessbyte chessbyte mentioned this pull request Mar 29, 2017
Closed
@Fryguy Fryguy merged commit a7323ae into ManageIQ:master Apr 17, 2017
@Fryguy Fryguy added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 17, 2017
@rodneyhbrown7
Copy link

Helps to remove blocks for ManageIQ/manageiq-ui-classic#970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fryguy Fryguy

Labels
enhancement providers/physical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@odravison @miq-bot @rodneyhbrown7 @blomquisg @Fryguy