Drop support for oVirt /api, always use /ovirt-engine/api #14469

jhernand · 2017-03-22T22:23:26Z

Versions of oVirt 3.4 and older only supported the /api path for access to the
API. Since version 3.5 /ovirt-engine/api is supported as well, and /api is
deprecated. In version 4.0 /api was removed completely. The provider has
supported both paths, which caused confusion and problems during upgrades. As
we no longer need to support oVirt 3.4 or older, that support can now be
removed. That is what this patch does. The path will be still saved to the
'path' column of the 'endpoints' table, but not used at all.

https://bugzilla.redhat.com/1427653

jhernand · 2017-03-22T22:24:11Z

@borod108 @masayag @pkliczewski @durandom please review.

jhernand · 2017-03-22T22:26:19Z

Note that the relevant changes are only in the api_integration.rb file. The rest is needed to change the hundreds of places where /api needs to be replaced by /ovirt-engine/api in the VC .yml files.

jhernand · 2017-03-22T22:28:37Z

@miq-bot add-labels bug providers/rhevm

miq-bot · 2017-03-22T22:29:04Z

@jhernand Cannot apply the following label because they are not recognized: bug providers/rhevm

jhernand · 2017-03-23T12:18:31Z

Addressed the Rubcop issues and the offending string issues.

jhernand · 2017-03-23T12:46:10Z

Bug 1427653 - Rhev inventory refresh fails after rhev upgrade from 3.6 to 4.0

miq-bot · 2017-03-27T16:11:29Z

This pull request is not mergeable. Please rebase and repush.

miq-bot · 2017-04-03T19:41:33Z

This pull request is not mergeable. Please rebase and repush.

durandom

code wise LGTM
@oourfali is this fine/yes ?
And I guess you have full oversight of the supported version implications, because reading the attached BZ lost me somehow :)

durandom · 2017-04-04T09:41:56Z

app/models/manageiq/providers/redhat/infra_manager/api_integration.rb

@@ -10,6 +10,8 @@ module ManageIQ::Providers::Redhat::InfraManager::ApiIntegration
    process_api_features_support
  end

+  DEFAULT_PATH = '/ovirt-engine/api'.freeze


is this used somewhere else than below? If not, I would just inline it (put the string where it's used)

It isn't used anywhere else. I will inline it.

jhernand · 2017-04-04T13:41:24Z

Removed the DEFAULT_PATH constant.

jhernand · 2017-04-04T13:42:01Z

Note that this should be fine/yes and euwe/yes, in my opinion.

Versions of oVirt 3.4 and older only supported the /api path for access to the API. Since version 3.5 /ovirt-engine/api is supported as well, and /api is deprecated. In version 4.0 /api was removed completely. The provider has supported both paths, which caused confusion and problems during upgrades. As we no longer need to support oVirt 3.4 or older, that support can now be removed. That is what this patch does. The path will be still saved to the 'path' column of the 'endpoints' table, but not used at all. https://bugzilla.redhat.com/1427653

miq-bot · 2017-04-04T13:47:21Z

Checked commit https://github.com/jhernand/manageiq/commit/543846bf888a5acc0eec7595dd517e5458f11727 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

oourfali · 2017-04-04T14:43:19Z

LGTM.
And yes @durandom , we are aware as for the supported versions.

durandom · 2017-04-04T15:00:51Z

@miq-bot assign @blomquisg
@miq-bot add_label fine/yes, euwe/yes

@blomquisg please merge

…rt_paths Drop support for oVirt /api, always use /ovirt-engine/api (cherry picked from commit ac8b311)

simaishi · 2017-04-06T22:47:50Z

Fine backport details:

$ git log -1
commit 919c52497b7845a902a525ac14d9525a234ee212
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Thu Apr 6 16:17:14 2017 -0400

    Merge pull request #14469 from jhernand/drop_support_for_multiple_ovirt_paths
    
    Drop support for oVirt /api, always use /ovirt-engine/api
    (cherry picked from commit ac8b311ff4ca26b6258f8962302784135fef1032)

simaishi · 2017-04-17T17:52:51Z

@jhernand It seems this PR depends on #14159 (which isn't currently marked as euwe/yes). Also, there are a few conflicts.. Can you please create an Euwe PR?

jhernand · 2017-04-18T08:05:30Z

Yes @simaishi , I am preparing the backport.

jhernand · 2017-04-18T09:08:20Z

@simaishi the euwe backport is here:

[EUWE] Drop support for oVirt /api, always use /ovirt-engine/api
#14786

simaishi · 2017-04-21T13:57:32Z

Backported to Euwe via #14786

chessbyte assigned oourfali Mar 22, 2017

chessbyte added the providers/rhevm label Mar 22, 2017

miq-bot added unmergeable and removed unmergeable labels Mar 27, 2017

miq-bot added unmergeable and removed unmergeable labels Apr 3, 2017

pkliczewski approved these changes Apr 4, 2017

View reviewed changes

durandom approved these changes Apr 4, 2017

View reviewed changes

miq-bot assigned blomquisg and unassigned oourfali Apr 4, 2017

miq-bot added euwe/yes labels Apr 4, 2017

blomquisg merged commit ac8b311 into ManageIQ:master Apr 6, 2017

blomquisg added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 6, 2017

simaishi pushed a commit that referenced this pull request Apr 6, 2017

Merge pull request #14469 from jhernand/drop_support_for_multiple_ovi…

919c524

…rt_paths Drop support for oVirt /api, always use /ovirt-engine/api (cherry picked from commit ac8b311)

simaishi added fine/backported and removed fine/yes labels Apr 6, 2017

simaishi added the euwe/conflict label Apr 17, 2017

jhernand mentioned this pull request Apr 18, 2017

[EUWE] Drop support for oVirt /api, always use /ovirt-engine/api #14786

Merged

simaishi removed the euwe/conflict label Apr 18, 2017

simaishi added euwe/backported and removed euwe/yes labels Apr 21, 2017

Fryguy added the providers/infrastructure label Jan 24, 2020

Fryguy unassigned blomquisg Jan 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop support for oVirt /api, always use /ovirt-engine/api #14469

Drop support for oVirt /api, always use /ovirt-engine/api #14469

jhernand commented Mar 22, 2017

jhernand commented Mar 22, 2017

jhernand commented Mar 22, 2017

jhernand commented Mar 22, 2017

miq-bot commented Mar 22, 2017

jhernand commented Mar 23, 2017

jhernand commented Mar 23, 2017

miq-bot commented Mar 27, 2017

miq-bot commented Apr 3, 2017

durandom left a comment

durandom Apr 4, 2017

jhernand Apr 4, 2017

jhernand commented Apr 4, 2017

jhernand commented Apr 4, 2017

miq-bot commented Apr 4, 2017

oourfali commented Apr 4, 2017

durandom commented Apr 4, 2017

simaishi commented Apr 6, 2017

simaishi commented Apr 17, 2017

jhernand commented Apr 18, 2017

jhernand commented Apr 18, 2017

simaishi commented Apr 21, 2017

Drop support for oVirt /api, always use /ovirt-engine/api #14469

Drop support for oVirt /api, always use /ovirt-engine/api #14469

Conversation

jhernand commented Mar 22, 2017

jhernand commented Mar 22, 2017

jhernand commented Mar 22, 2017

jhernand commented Mar 22, 2017

miq-bot commented Mar 22, 2017

jhernand commented Mar 23, 2017

jhernand commented Mar 23, 2017

miq-bot commented Mar 27, 2017

miq-bot commented Apr 3, 2017

durandom left a comment

Choose a reason for hiding this comment

durandom Apr 4, 2017

Choose a reason for hiding this comment

jhernand Apr 4, 2017

Choose a reason for hiding this comment

jhernand commented Apr 4, 2017

jhernand commented Apr 4, 2017

miq-bot commented Apr 4, 2017

oourfali commented Apr 4, 2017

durandom commented Apr 4, 2017

simaishi commented Apr 6, 2017

simaishi commented Apr 17, 2017

jhernand commented Apr 18, 2017

jhernand commented Apr 18, 2017

simaishi commented Apr 21, 2017