Pass additional metadata from alert to event #14301
Conversation
|
@miq-bot add_label enhancement, providers/containers, wip |
moolitayer
force-pushed
the
additional_alert_meta
branch
from
ab31708
to
3464e8c
Compare
moolitayer
force-pushed
the
additional_alert_meta
branch
2 times, most recently
from
46bb8ff
to
916ddff
Compare
moolitayer
changed the title
|
@miq-bot remove_label wip |
|
@gmcculloug can you please review? |
|
@simon3z @gmcculloug could you please review? |
app/models/ems_event.rb
Outdated
| @@ -178,6 +178,8 @@ def parse_event_metadata | |||
| event_type == "datawarehouse_alert" ? message : nil, | |||
| full_data.try(:[], :severity), | |||
| full_data.try(:[], :url), | |||
| full_data.try(:[], :ems_ref), | |||
| full_data.try(:[], :resolved), | |||
There was a problem hiding this comment.
The try logic is getting ugly. It makes more sense to initialize full_data at the top of the method if it is nil then just reference the hash normally.
def parse_event_metadata
full_data ||= {}
[
event_type == "datawarehouse_alert" ? message : nil,
full_data.[:severity],
full_data[:url],
full_data[:ems_ref],
full_data[:resolved]
]
end
moolitayer
force-pushed
the
additional_alert_meta
branch
from
916ddff
to
95ebfe0
Compare
|
Checked commit moolitayer@95ebfe0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@gmcculloug could you take another look please? |
|
Code-wise LGTM 👍 @miq-bot assign gmcculloug |
|
@gmcculloug please take another look |
|
@moolitayer Please label |
|
@miq-bot add_label fine/no |
Depends on #14295 [merged]