boot skips all seeding with env variable

[kbrock]

This is a follow-up to #6672

We need to reboot rails s dozens of times a day as we run performance tests, often in production mode.

On appliance startup, the environment variable SKIP_PRIMORDIAL_SEEDSKIP_SEEDING is consulted when booting the appliance to skip seeding the database.

Using a docker db, local rails s takes 18s. Using this flag takes it down to 9s (50% savings).

For evm server, it was only skipping the first half of the seeding. This PR skips the second half of seeding

/cc @jrafanie @Fryguy @chrisarcand same actors as last round.

[jrafanie]

On appliance startup, the environment variable SKIP_PRIMORDIAL_SEED is consulted when booting the appliance to skip seeding the database. [

@kbrock Are you saying the appliance skips primordial seed by default? I don't see it being set here

Is this setting only for performance and development testing?

[kbrock]

@jrafanie that setting is only used for performance and development
It is a hidden lever that would allow high latency customers to boot up.

[isimluk]

👍 I am tentatively liking it.

[jrafanie]

@kbrock My only problem is this SKIP_PRIMORDIAL_SEED would basically skip all seeding if you have it set and the MiqDatabase has been seeded. It makes the env variable name wrong. 😢

[kbrock]

@jrafanie Ok. As it stands, the environment variable will skip the primordial seeding but not skip the other seeding. Not good.

This PR is a minimal change to fix the problem and buy us time before we properly seed the database. Not on every evm start.

[jrafanie]

@jrafanie Ok. As it stands, the environment variable will skip the primordial seeding but not skip the other seeding. Not good.

@kbrock yeah, but it's called SKIP_PRIMORDIAL_SEED, that's what it does. If you change it to do all seeds, the variable needs to be renamed. If you want to have a ENV to skip it all, create SKIP_ALL_SEED right or we'll have to rename it. I'm not sure how many places know about the existing variable. Maybe just rename variable.

[chessbyte]

Maybe the simpler SKIP_SEEDING will do

[jrafanie]

Maybe the simpler SKIP_SEEDING will do

hehe, naming is hard. Great idea, @chessbyte

[kbrock]

thanks. I was told that was too short ;) #6672 (comment) 🚌

[jrafanie]

@kbrock maybe because that's when we were just skipping primordial but not the rest. Maybe it's fine if we skip all of the seeding if MiqDatabase is present?

We should go with WE_STINK_AND_OUR_SEEDS_ARE_SLOW from here

😆

[kbrock]

@chessbyte thanks. changed name to SKIP_SEEDING

Any other changes?

[jrafanie]

LGTM, just squash the commits unless you think they stand alone... and update the description @kbrock

[miq-bot]

Some comments on commit kbrock@31241cd

lib/evm_database.rb

• ⚠️ - 48 - Detected puts. Remove all debugging statements.
• ⚠️ - 49 - Detected puts. Remove all debugging statements.

[miq-bot]

Checked commit kbrock@31241cd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 2 offenses detected

lib/evm_database.rb

• ❗ - Line 48, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• ❗ - Line 49, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.